Skip to content

Conversation

@xakep-amatop
Copy link
Contributor

Add support of voltage control to Renesas PFC driver. Voltage register mappings have been added to r8a77951 and r8a77961 SoCs.

Allow 'power-source' property for 'renesas,rcar-pfc' node. This property will be used for configuring IO voltage on appropriate pin. For now it is possible to have only two voltages: 1.8 and 3.3.

Note: it is possible to change voltage only for SD/MMC pins on r8a77951 and r8a77961 SoCs.

@xakep-amatop xakep-amatop marked this pull request as ready for review July 17, 2023 12:26
@zephyrbot zephyrbot added area: ARM64 ARM (64-bit) Architecture area: Pinctrl platform: Renesas R-Car Renesas R-Car platform: Renesas R-Car ARM64 Renesas Electronics Corporation, R-Car ARM64 area: Devicetree Binding PR modifies or adds a Device Tree binding labels Jul 17, 2023
Comment on lines 15 to 18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this name is too generic, please namespace this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, this looks like a pinctrl driver option, why in soc/?

Copy link
Member

@aaillet aaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR
Why would this feature be an option ?
Please wait for #56043 before merging this in order for it not to be updated at each PR merge.

Add support of voltage control to Renesas PFC driver. Voltage register
mappings have been added to r8a77951 and r8a77961 SoCs.

Allow 'power-source' property for 'renesas,rcar-pfc' node. This property
will be used for configuring IO voltage on appropriate pin. For now it
is possible to have only two voltages: 1.8 and 3.3.

Note: it is possible to change voltage only for SD/MMC pins on r8a77951
      and r8a77961 SoCs.

Signed-off-by: Mykola Kvach <[email protected]>
@xakep-amatop xakep-amatop force-pushed the rcar-pfc-add-support-of-voltage-control branch from 63ec362 to 12a7967 Compare August 2, 2023 12:15
@xakep-amatop
Copy link
Contributor Author

@gmarull

this name is too generic, please namespace this

done

also, this looks like a pinctrl driver option, why in soc/?

you're right, done!


@aaillet

Please also add the feature and pin list to the arm(32) side of the soc !

added!

Why would this feature be an option ?

To be able to disable this feature for debugging purposes, and with the config, we don't need to care about the existence of PFC SoC changes for other boards (like ARM32 or Gen4).

Please wait for #56043 before merging this in order for it not to be updated at each PR merge.

Okay, I'll wait, but I don't see any major merging conflicts between these two PRs.

@xakep-amatop xakep-amatop requested review from aaillet and gmarull August 2, 2023 12:23
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Oct 2, 2023
@github-actions github-actions bot closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ARM64 ARM (64-bit) Architecture area: Devicetree Binding PR modifies or adds a Device Tree binding area: Pinctrl platform: Renesas R-Car ARM64 Renesas Electronics Corporation, R-Car ARM64 platform: Renesas R-Car Renesas R-Car Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants